[SPARK-5503][MLLIB] Example code for Power Iteration Clustering by javadba · Pull Request #4495 · apache/spark

javadba · 2015-02-10T06:34:14Z

No description provided.

SparkQA · 2015-02-10T06:37:27Z

Test build #27180 has started for PR 4495 at commit efeec45.

This patch merges cleanly.

SparkQA · 2015-02-10T06:38:28Z

Test build #27180 has finished for PR 4495 at commit efeec45.

This patch fails Scala style tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-10T06:38:29Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27180/
Test FAILed.

SparkQA · 2015-02-10T06:47:38Z

Test build #27182 has started for PR 4495 at commit f7ff43d.

This patch merges cleanly.

mengxr · 2015-02-10T07:02:22Z

examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala

organize imports (You can use this plugin: https://plugins.jetbrains.com/plugin/7350)

I had already manually fixed the order according to your email. Maybe I did optimize imports again: since the above shows the order was reset .. Apparently the default behavior in IJ is completely different than the spark requirements. Will try that plugin.

That plugin is apparently for IJ13 and says should not be used. So that is a bit confusing.. anyways I did some more manual rearranging.

mengxr · 2015-02-10T07:04:19Z

@javadba Please also check the hidden inline comments.

SparkQA · 2015-02-10T07:22:54Z

Test build #27185 has started for PR 4495 at commit cef28f4.

This patch merges cleanly.

SparkQA · 2015-02-10T08:06:46Z

Test build #27182 has finished for PR 4495 at commit f7ff43d.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- case class Params(

AmplabJenkins · 2015-02-10T08:06:51Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27182/
Test PASSed.

SparkQA · 2015-02-10T08:38:51Z

Test build #27185 has finished for PR 4495 at commit cef28f4.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- case class Params(

AmplabJenkins · 2015-02-10T08:38:55Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27185/
Test PASSed.

SparkQA · 2015-02-10T20:17:30Z

Test build #27228 has started for PR 4495 at commit d7ac350.

This patch merges cleanly.

SparkQA · 2015-02-10T21:12:27Z

Test build #27228 has finished for PR 4495 at commit d7ac350.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-10T21:12:30Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27228/
Test FAILed.

mengxr · 2015-02-10T23:28:03Z

@javadba I still want to decrease the code complexity because this is example code, so users can focus on the PIC part of the code but not on how to prepare the input. There are two things we can change:

ask users to input the size of the smallest circle instead of total number of points
do not treat the radius of smallest circle differently
remove similarity and use gaussianSimilarity directly

SparkQA · 2015-02-11T00:02:35Z

Test build #27245 has started for PR 4495 at commit 2878675.

This patch merges cleanly.

SparkQA · 2015-02-11T01:19:40Z

Test build #27245 has finished for PR 4495 at commit 2878675.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-11T01:19:43Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27245/
Test PASSed.

mengxr · 2015-02-11T02:48:23Z

examples/src/main/scala/org/apache/spark/examples/mllib/PowerIterationClusteringExample.scala

We still use 2-space indentation here. 4-indentation only applies to method/class declarations.

err yes.. back to the drawing board for the IJ auto formatting.

fyi I have created a Youtrack issue for Intellij for this formatting limitation:

https://youtrack.jetbrains.com/issue/IDEA-136404

SparkQA · 2015-02-11T22:42:31Z

Test build #27306 has started for PR 4495 at commit 3c84b14.

This patch merges cleanly.

SparkQA · 2015-02-12T00:07:54Z

Test build #27306 has finished for PR 4495 at commit 3c84b14.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-12T00:07:58Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27306/
Test PASSed.

Author: sboeschhuawei <stephen.boesch@huawei.com> Closes #4495 from javadba/picexamples and squashes the following commits: 3c84b14 [sboeschhuawei] PIC Examples updates from Xiangrui's comments round 5 2878675 [sboeschhuawei] Fourth round with xiangrui on PICExample d7ac350 [sboeschhuawei] Updates to PICExample from Xiangrui's comments round 3 d7f0cba [sboeschhuawei] Updates to PICExample from Xiangrui's comments round 3 cef28f4 [sboeschhuawei] Further updates to PICExample from Xiangrui's comments f7ff43d [sboeschhuawei] Update to PICExample from Xiangrui's comments efeec45 [sboeschhuawei] Update to PICExample from Xiangrui's comments 03e8de4 [sboeschhuawei] Added PICExample c509130 [sboeschhuawei] placeholder for pic examples 5864d4a [sboeschhuawei] placeholder for pic examples (cherry picked from commit e1a1ff8) Signed-off-by: Xiangrui Meng <meng@databricks.com>

mengxr · 2015-02-13T17:46:57Z

LGTM. Merged into master and branch-1.3. Thanks!!

sboeschhuawei added 4 commits February 4, 2015 12:08

placeholder for pic examples

5864d4a

placeholder for pic examples

c509130

Added PICExample

03e8de4

Update to PICExample from Xiangrui's comments

efeec45

Update to PICExample from Xiangrui's comments

f7ff43d

mengxr reviewed Feb 10, 2015
View reviewed changes

Further updates to PICExample from Xiangrui's comments

cef28f4

sboeschhuawei added 2 commits February 10, 2015 12:12

Updates to PICExample from Xiangrui's comments round 3

d7f0cba

Updates to PICExample from Xiangrui's comments round 3

d7ac350

Fourth round with xiangrui on PICExample

2878675

mengxr reviewed Feb 11, 2015
View reviewed changes

PIC Examples updates from Xiangrui's comments round 5

3c84b14

asfgit closed this in e1a1ff8 Feb 13, 2015

Conversation

javadba commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

AmplabJenkins commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

mengxr Feb 10, 2015

Choose a reason for hiding this comment

Uh oh!

javadba Feb 10, 2015

Choose a reason for hiding this comment

Uh oh!

javadba Feb 10, 2015

Choose a reason for hiding this comment

Uh oh!

mengxr commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

AmplabJenkins commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

AmplabJenkins commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 10, 2015

Uh oh!

AmplabJenkins commented Feb 10, 2015

Uh oh!

mengxr commented Feb 10, 2015

Uh oh!

SparkQA commented Feb 11, 2015

Uh oh!

SparkQA commented Feb 11, 2015

Uh oh!

AmplabJenkins commented Feb 11, 2015

Uh oh!

mengxr Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

javadba Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

javadba Feb 11, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Feb 11, 2015

Uh oh!

SparkQA commented Feb 12, 2015

Uh oh!

AmplabJenkins commented Feb 12, 2015

Uh oh!

mengxr commented Feb 13, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants